Updating lint tox rule #1348
Merged
Updating lint tox rule #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We require a script (Python or bash) since we only run pep8 on files that are checked in to the repo by using `git ls-files`. (Prior to this change, spurious Python files would cause `tox -e lint` to fail.)
googlebot
added
the
cla: yes
8 tasks
| TEST_RC = 'pylintrc_reduced' | ||
| SCRIPTS_DIR = os.path.abspath(os.path.dirname(__file__)) | ||
| PRODUCTION_RC = os.path.join(SCRIPTS_DIR, 'pylintrc_default') | ||
| TEST_RC = os.path.join(SCRIPTS_DIR, 'pylintrc_reduced') |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM |
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Jan 8, 2016
Also making pep8_on_repo exit with the correct status code. This was a bug introduced in googleapis#1348.
parthea
pushed a commit
that referenced
this pull request
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two chief changes
run_pylintandpylintrc_defaultinto thescripts/directory (along with all other scripts used bytox)pep8_on_repo.shforpep8_on_repo.pyto avoid usingbash. (We require a script --Python or bash -- since we only runpep8on files that are checked in to the repo by usinggit ls-files. Prior to this change, spurious Python files would causetox -e lintto fail.)@tseaver I decided to do this partially because of fix-ups for #714 and partially for #1123.