Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider providing a warning for an invalid keyfile #768

Closed
robertdimarco opened this issue Jul 31, 2015 · 2 comments
Closed

Consider providing a warning for an invalid keyfile #768

robertdimarco opened this issue Jul 31, 2015 · 2 comments
Assignees

Comments

@robertdimarco
Copy link
Contributor

When creating a keyfile for a service account according to GoogleCloudPlatform/gcloud-node#elsewhere, it seems that the client_email and client_id fields are sometimes empty, even though (I think) they are both required to be the email address of the service account. Trying to use that credential with this module and Cloud Datastore or Cloud Storage will return an 'Invalid Grant' error when making requests.

This is just a suggestion (feel free to close-out as wont-fix) but it might be worth adding a warning from this module when those fields are missing / empty strings.

@stephenplusplus
Copy link
Contributor

Thanks for the idea, and sorry for the delay in addressing it. Our auth goes through a few layers in many directions depending on the input received (keyfile vs credentials object/JSON key vs p12 key vs pem key, etc...), but after merging googleapis/node-gtoken#3, I think all of the holes are covered. If something is missing from any given auth input type, it should now be reported when something isn't provided before a Google API request is made.

@robertdimarco
Copy link
Contributor Author

👍

sofisl pushed a commit that referenced this issue Nov 17, 2022
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 468790263

Source-Link: googleapis/googleapis@873ab45

Source-Link: googleapis/googleapis-gen@cb6f37a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2I2ZjM3YWVmZjJhMzQ3MmU0MGE3YmJhY2U4YzY3ZDc1ZTI0YmVlNSJ9

feat: Update Compute Engine API to revision 20220720 (#723)
Source-Link: googleapis/googleapis@60a0fa7

Source-Link: googleapis/googleapis-gen@ba1df1b
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYmExZGYxYmU5M2Y1YTFhYTVjNjQ3ZmMyZjE5NWQ0MWIwMDc1YWE5MyJ9
sofisl pushed a commit that referenced this issue Jan 24, 2023
... chore: update gapic-generator-ruby to the latest commit chore: release gapic-generator-typescript 1.5.0

Committer: @miraleung
PiperOrigin-RevId: 380641501

Source-Link: googleapis/googleapis@076f7e9

Source-Link: googleapis/googleapis-gen@27e4c88
sofisl pushed a commit that referenced this issue Jan 25, 2023
... chore: update gapic-generator-ruby to the latest commit chore: release gapic-generator-typescript 1.5.0

Committer: @miraleung
PiperOrigin-RevId: 380641501

Source-Link: googleapis/googleapis@076f7e9

Source-Link: googleapis/googleapis-gen@27e4c88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants