Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to ensure we use lower-case gRPC header keys #1545

Closed
omaray opened this issue Aug 30, 2016 · 1 comment
Closed

Need to ensure we use lower-case gRPC header keys #1545

omaray opened this issue Aug 30, 2016 · 1 comment
Assignees
Labels

Comments

@omaray
Copy link

omaray commented Aug 30, 2016

This might be a no-op, but please double check. Filing this issue just in case.

We need to ensure that all headers used for gRPC are written in lower-case. Please review this Pull Request for reference of what needs to be updated.

Again, perhaps this doesn't apply to your language. Feel free to comment and then close the issue (after double checking).

@stephenplusplus
Copy link
Contributor

This is actually quite well timed, since we just got an issue about setting headers for Datastore: #1542. That issue already specifies the headers as lowercase, so I'll just be copying from that example.

As our library stands currently, we don't set any headers at all. That's handled in gRPC for us, we just give it an auth client from google-auth-library and it figures out the rest.

sofisl pushed a commit that referenced this issue Nov 16, 2022
Source-Link: googleapis/synthtool@d229a12
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:74ab2b3c71ef27e6d8b69b1d0a0c9d31447777b79ac3cd4be82c265b45f37e5e

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Alexander Fenster <fenster@google.com>
sofisl pushed a commit that referenced this issue Nov 17, 2022
Source-Link: googleapis/synthtool@d229a12
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-nodejs:latest@sha256:74ab2b3c71ef27e6d8b69b1d0a0c9d31447777b79ac3cd4be82c265b45f37e5e

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Alexander Fenster <fenster@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants