Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerating Pub/Sub and Logging #1156

Merged
merged 2 commits into from
Aug 12, 2016
Merged

Conversation

garrettjonesgoogle
Copy link
Member

Version updates:

  • GAX -> 0.0.14
  • gRPC -> 0.15.0
  • generated grpc packages:
    • grpc-google-common-protos:0.0.7 (now includes logging/types, so that a separate package is not needed for that)
    • grpc-google-logging-v2:0.0.7
    • grpc-google-pubsub-v1:0.0.7

Generated code changes:

  • createWithDefaults renamed to create (not used by the handwritten layer)
  • removing editing instructions - there has not been a demonstrated need for this, so we have tabled it
  • more informative failures when resource names are not formatted right
  • enhancements/fixes in sample code
  • hiding static final fields, making static accessors
  • adding package-info.java files
  • adding a missing 'final' on one particular type of api method

Notes:

  • The documentation changes for pubsub are due to undoing our local pubsub.proto edits; this is not feasible to maintain in the long-term, and we need to get the edits fixed at its source.

Proto/GAPIC configuration changes:

  • Logging changed some proto field names (e.g. project -> parent)
  • GAPIC configuration changes for pubsub (retry values, pubsub endpoint (removing -experimental))

Sorry about the continued usage of baselines - we are working on a way to get rid of them.

FYI @michaelbausor @shinfan

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 11, 2016
@coveralls
Copy link

coveralls commented Aug 11, 2016

Coverage Status

Coverage decreased (-0.06%) to 85.846% when pulling 016cc2d on garrettjonesgoogle:master into c4d8e48 on GoogleCloudPlatform:master.

@@ -458,7 +458,7 @@ public Builder toBuilder() {
// todo(mziccard) uncomment when #1042 gets fixed
// builder.setCacheLookup(cacheLookup);
builder.setCacheHit(cacheHit);
builder.setValidatedWithOriginServer(cacheValidatedWithOriginServer);
builder.setCacheValidatedWithOriginServer(cacheValidatedWithOriginServer);

This comment was marked as spam.

This comment was marked as spam.

@garrettjonesgoogle
Copy link
Member Author

In the logging code, I renamed formatProjectName to formatParentName, and fixed the method that was accidentally made private. PTAL.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 85.851% when pulling c666e05 on garrettjonesgoogle:master into c4d8e48 on GoogleCloudPlatform:master.

@mziccard
Copy link
Contributor

LGTM!

@mziccard mziccard merged commit 1c30bf9 into googleapis:master Aug 12, 2016
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this pull request Jun 29, 2022
… (googleapis#549)

Source-Link: googleapis/synthtool@5d3c52f
Post-Processor: gcr.io/repo-automation-bots/owlbot-java:latest@sha256:b3f8a219abf58ed4a775da5b90934b34f477b74f6f4e5d15781694dcc67b6f41
github-actions bot pushed a commit that referenced this pull request Jul 1, 2022
Source-Link: googleapis/synthtool@5d3c52f
Post-Processor: gcr.io/repo-automation-bots/owlbot-java:latest@sha256:b3f8a219abf58ed4a775da5b90934b34f477b74f6f4e5d15781694dcc67b6f41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants