Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing configuration for dryRun jobs causes NPE #525

Closed
mziccard opened this issue Jan 6, 2016 · 9 comments
Closed

Missing configuration for dryRun jobs causes NPE #525

mziccard opened this issue Jan 6, 2016 · 9 comments
Assignees
Labels
api: bigquery Issues related to the BigQuery API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Milestone

Comments

@mziccard
Copy link
Contributor

mziccard commented Jan 6, 2016

A query job created with dryRun = true has no configuration field. The following is the response I get from Jobs: insert.

{
 "kind": "bigquery#job",
 "etag": "\"Bop49sEVg6UBKwr7tLdL8AavHaw/LRPbO11E3VlTAE5UxM2F_Mfu01M\"",
 "jobReference": {
  "projectId": "gcloud-devel"
 },
 "status": {
  "state": "DONE"
 },
 "statistics": {
  "creationTime": "1452067884640",
  "totalBytesProcessed": "26",
  "query": {
   "totalBytesProcessed": "26",
   "totalBytesBilled": "0",
   "cacheHit": false
  }
 }
}

While if I create the same job with dryRun = false the configuration is present instead:

{
 "kind": "bigquery#job",
 "etag": "\"Bop49sEVg6UBKwr7tLdL8AavHaw/OI0lGTx2GlKc0VoAAYS-fIXHWok\"",
 "id": "gcloud-devel:job_nixqXTMu-mS9U26Ixnxr9KZxCyc",
 "selfLink": "https://www.googleapis.com/bigquery/v2/projects/gcloud-devel/jobs/job_nixqXTMu-mS9U26Ixnxr9KZxCyc",
 "jobReference": {
  "projectId": "gcloud-devel",
  "jobId": "job_nixqXTMu-mS9U26Ixnxr9KZxCyc"
 },
 "configuration": {
  "query": {
   "query": "select StringField from gcloud_test_dataset_temp_6c127c49_9574_4e17_ad2b_8e85071997aa.testing_table",
   "destinationTable": {
    "projectId": "gcloud-devel",
    "datasetId": "_6bb2fc157573f6bd0fed98f3b039c1e71f26d7d1",
    "tableId": "anon5f489e91b602aaed3dc62a46d51ba3c070e5d03f"
   },
   "createDisposition": "CREATE_IF_NEEDED",
   "writeDisposition": "WRITE_TRUNCATE"
  },
  "dryRun": false
 },
 "status": {
  "state": "RUNNING"
 },
 "statistics": {
  "creationTime": "1452070358348",
  "startTime": "1452070358585"
 },
 "user_email": "..."
}

While this does not affect the functionality itself I was wondering whether configuration should be returned also for dry-run jobs for consistency? /cc @jcondit @jtigani

For what concerns gcloud-java the absence of a configuration causes a NPE to be thrown at JobInfo:297.

@mziccard mziccard added the api: bigquery Issues related to the BigQuery API. label Jan 6, 2016
@jcondit
Copy link

jcondit commented Jan 6, 2016

Yeah, looks like a bug on our end. Thanks for the report!

@aozarov aozarov added the type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. label Jan 6, 2016
@aozarov aozarov added this to the Big Query Stable milestone Jan 6, 2016
@polleyg
Copy link

polleyg commented Jan 12, 2017

Is there any ETA on a roll-out for this fix? I've just hit this bug.

http://stackoverflow.com/questions/41604995/bigquery-client-library-throwing-npe-when-setting-dryrun-to-true

@jcondit
Copy link

jcondit commented Jan 12, 2017

I've pinged our internal bug to see if we can get the API behavior straightened out.

In the meantime, perhaps we can fix the NPE in the client library independently? @tswast

@jcondit
Copy link

jcondit commented Jan 18, 2017

We've submitted a fix for this issue on the backend. It'll take a week or two to roll out.

@tswast
Copy link
Contributor

tswast commented Feb 10, 2017

Marking as blocking GA, just to make sure we double check that this is working and close this out. Sorry I didn't have time to make a quick fix.

@garrettjonesgoogle
Copy link
Member

@jcondit where is the backend fix now?

@jcondit
Copy link

jcondit commented Mar 11, 2017

Deployed to prod.

@garrettjonesgoogle
Copy link
Member

@jcondit Thanks!

Next we just need to verify that the client library code works ok in the formerly-problematic scenario.

@shinfan shinfan modified the milestones: Big Query Stable, BigQuery GA May 8, 2017
@shinfan shinfan added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed triaged for beta labels May 8, 2017
@garrettjonesgoogle
Copy link
Member

I have verified it by writing a new integration test in #2328 .

Closing this issue now.

github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this issue Jun 29, 2022
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this issue Jun 29, 2022
)

* chore: update dependencies for regapic

* add more dependencies and trigger comment

* update goldens

* fix indentation

* remove duplicate gax-httpjson dependency

* remove duplicated dependencies
Source-Link: googleapis/synthtool@fa54eb2
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:1ec28a46062b19135b11178ceee60231e5f5a92dab454e23ae0aab72cd875906
github-actions bot pushed a commit that referenced this issue Jul 18, 2022
…tp to v1.8.1 (#525)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.auth:google-auth-library-oauth2-http](https://github.com/googleapis/google-auth-library-java) | `1.8.0` -> `1.8.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.auth:google-auth-library-oauth2-http/1.8.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.auth:google-auth-library-oauth2-http/1.8.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.auth:google-auth-library-oauth2-http/1.8.1/compatibility-slim/1.8.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.auth:google-auth-library-oauth2-http/1.8.1/confidence-slim/1.8.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/google-auth-library-java</summary>

### [`v1.8.1`](https://github.com/googleapis/google-auth-library-java/blob/HEAD/CHANGELOG.md#&#8203;181-httpsgithubcomgoogleapisgoogle-auth-library-javacomparev180v181-2022-07-13)

[Compare Source](https://github.com/googleapis/google-auth-library-java/compare/v1.8.0...v1.8.1)

##### Bug Fixes

-   enable longpaths support for windows test ([#&#8203;1485](https://github.com/googleapis/google-auth-library-java/issues/1485)) ([#&#8203;943](https://github.com/googleapis/google-auth-library-java/issues/943)) ([c21ec6c](https://github.com/googleapis/google-auth-library-java/commit/c21ec6c952b8bb8fb8bc2e2f1b260beb330a3cd2))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-analytics-data).
github-actions bot pushed a commit that referenced this issue Jul 20, 2022
…plugin to v3 (#525)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [org.apache.maven.plugins:maven-deploy-plugin](https://maven.apache.org/plugins/) | `2.8.2` -> `3.0.0` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.0.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.0.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.0.0/compatibility-slim/2.8.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-deploy-plugin/3.0.0/confidence-slim/2.8.2)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dialogflow-cx).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMTcuNCIsInVwZGF0ZWRJblZlciI6IjMyLjExNy40In0=-->
github-actions bot pushed a commit that referenced this issue Aug 9, 2022
🤖 I have created a release *beep* *boop*
---


## [0.14.3](googleapis/java-analytics-data@v0.14.2...v0.14.3) (2022-08-09)


### Dependencies

* update dependency com.google.auth:google-auth-library-oauth2-http to v1.8.1 ([#525](googleapis/java-analytics-data#525)) ([44ba0c5](googleapis/java-analytics-data@44ba0c5))
* update dependency com.google.auth:google-auth-library-oauth2-http to v1.9.0 ([#533](googleapis/java-analytics-data#533)) ([0d03506](googleapis/java-analytics-data@0d03506))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#530](googleapis/java-analytics-data#530)) ([ed6d446](googleapis/java-analytics-data@ed6d446))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
…1.1 (#525)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://github.com/googleapis/java-cloud-bom)) | `26.1.0` -> `26.1.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/compatibility-slim/26.1.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.1/confidence-slim/26.1.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-retail).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xODQuMiIsInVwZGF0ZWRJblZlciI6IjMyLjE4NC4yIn0=-->
github-actions bot pushed a commit that referenced this issue Sep 15, 2022
…ator_java versions (#525)

- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 472750037

Source-Link: googleapis/googleapis@88f2ea3

Source-Link: googleapis/googleapis-gen@230a558
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjMwYTU1ODgzMDZhYWUxOGZlOGYyYTU3ZjE0ZDQwMzlhZDcyYzkwMSJ9
suztomo pushed a commit that referenced this issue Feb 1, 2023
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the BigQuery API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

8 participants