Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Discourage use of API_KEY in translate #1594

Closed
gguuss opened this issue Feb 7, 2017 · 1 comment
Closed

Feature Request: Discourage use of API_KEY in translate #1594

gguuss opened this issue Feb 7, 2017 · 1 comment
Assignees
@tcoffee-google
Labels
api: translation Issues related to the Cloud Translation API API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release.
Milestone
Translate GA

Comments

@gguuss
Copy link
Contributor

gguuss commented Feb 7, 2017

At the request of @puneith, we should remove, deprecate, or otherwise discourage using the API_KEY form of authorization favoring the GOOGLE_APPLICATION_CREDENTIALS for Cloud APIs to make the library consistent with the Python client library for Translate.

The affected method is setApiKey in the TranslateOptions builder.
@garrettjonesgoogle garrettjonesgoogle added the api: translation Issues related to the Cloud Translation API API. label Feb 18, 2017
@garrettjonesgoogle garrettjonesgoogle modified the milestone: Translate GA Jun 1, 2017
@garrettjonesgoogle garrettjonesgoogle added the priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. label Jun 2, 2017
tcoffee-google added a commit to tcoffee-google/google-cloud-java that referenced this issue Jun 14, 2017
@tcoffee-google
Discourage use of API key in translation
780042d 
Addresses googleapis#1594.
This was referenced Jun 14, 2017
Merged
Closed
tcoffee-google added a commit to tcoffee-google/google-cloud-java that referenced this issue Jun 16, 2017
@tcoffee-google
Discourage use of API key in translation
42afcd1 
Addresses googleapis#1594.
tcoffee-google added a commit that referenced this issue Jun 23, 2017
@tcoffee-google
Discourage use of API key in translation (#2147)
a898acc 
Addresses #1594.
@tcoffee-google
Copy link
Contributor

Fixed by #2147.

tcoffee-google added a commit to tcoffee-google/google-cloud-java that referenced this issue Jun 30, 2017
@tcoffee-google
Make Translate auth documentation clear and consistent
b89d7d1 
Additional updates prompted by googleapis#1594 / googleapis#2147.
@tcoffee-google tcoffee-google mentioned this issue Jun 30, 2017
Merged
tcoffee-google added a commit that referenced this issue Jul 14, 2017
@tcoffee-google
Make Translate auth documentation clear and consistent (#2208)
8e074f3 
* Make Translate auth documentation clear and consistent

Additional updates prompted by #1594 / #2147.

* Fix doc link

* Fix Spanner doc example

* Work around Javadoc bug

https://bugs.openjdk.java.net/browse/JDK-8130754
github-actions bot pushed a commit that referenced this issue Sep 30, 2022
@gcf-owl-bot @diegomarquezp
chore: exclude requirements.txt file from renovate-bot (#1594) (#95)
0890085 
* chore: exclude requirements.txt file from renovate-bot (#1594)

Source-Link: googleapis/synthtool@f58d313
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:f14e3fefe8e361e85752bd9890c8e56f2fe25f1e89cbb9597e4e3c7a429203a3

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Diego Alonso Marquez Palacios <diegomarquezp@google.com>
suztomo pushed a commit that referenced this issue Feb 1, 2023
@gcf-owl-bot
chore: exclude requirements.txt file from renovate-bot (#1594) (#933)
394f449 
Source-Link: googleapis/synthtool@f58d313
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:f14e3fefe8e361e85752bd9890c8e56f2fe25f1e89cbb9597e4e3c7a429203a3
suztomo pushed a commit that referenced this issue Feb 1, 2023
@gcf-owl-bot
chore: exclude requirements.txt file from renovate-bot (#1594) (#438)
52d5e12 
Source-Link: googleapis/synthtool@f58d313
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:f14e3fefe8e361e85752bd9890c8e56f2fe25f1e89cbb9597e4e3c7a429203a3
suztomo pushed a commit that referenced this issue Feb 1, 2023
@gcf-owl-bot
chore: exclude requirements.txt file from renovate-bot (#1594) (#811)
7ebbe69 
Source-Link: googleapis/synthtool@f58d313
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:f14e3fefe8e361e85752bd9890c8e56f2fe25f1e89cbb9597e4e3c7a429203a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tcoffee-google tcoffee-google

Labels
api: translation Issues related to the Cloud Translation API API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release.
Projects
None yet
Milestone
Translate GA
Development

No branches or pull requests
3 participants
@gguuss @garrettjonesgoogle @tcoffee-google