-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(firestore): adds COUNT aggregation query #6692
Conversation
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
for _, res := range responses { | ||
switch res := res.(type) { | ||
case *pb.RunAggregationQueryResponse: | ||
if err := qs.Send(res); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
return qs.Send(res)
With a return in each branch, you can also remove the return nil
outside of the statement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compiler doesn't like it when I remove the return
statement, even when I add a return nil
after the if
in the first branch.
This PR implements the StructuredAggregationQuery feature for Firestore.