Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bigtable): loadtest support app profile #5882

Merged
merged 4 commits into from
May 2, 2022
Merged

feat(bigtable): loadtest support app profile #5882

merged 4 commits into from
May 2, 2022

Conversation

stephennancekivell
Copy link
Contributor

Hi, I found using an app profile greatly improved my 99th performance. So it would be nice to support it profiles in loadtest.

Can be used like this.

./loadtest -project $PROJECT -instance $INSTANCE
2022/04/11 17:06:02 -creds flag unset, will use gcloud credential
2022/04/11 17:06:03 Dialing connections...
2022/04/11 17:06:03 Setting up scratch table...
2022/04/11 17:06:47 Starting load test... (run for 5s)
2022/04/11 17:06:58 Reads (2036 ok / 2036 tries):
min:             3.55575ms
median:          5.755416ms
max:             7.140176875s
95th percentile: 1.187244416s
99th percentile: 6.039376264s
2022/04/11 17:06:58 Writes (2060 ok / 2060 tries):
min:             3.952833ms
median:          6.225167ms
max:             7.369702958s
95th percentile: 1.47177056s
99th percentile: 5.784249186s
➜  bigtable git:(main) ✗ ./loadtest -project $PROJECT -instance $INSTANCE -app_profile syd
2022/04/11 17:07:05 -creds flag unset, will use gcloud credential
2022/04/11 17:07:06 Dialing connections...
2022/04/11 17:07:06 Setting up scratch table...
2022/04/11 17:08:36 Starting load test... (run for 5s)
2022/04/11 17:08:41 Reads (18951 ok / 18951 tries):
min:             3.921583ms
median:          10.810541ms
max:             315.866792ms
95th percentile: 22.642271ms
99th percentile: 40.233812ms
2022/04/11 17:08:41 Writes (18686 ok / 18686 tries):
min:             4.494417ms
median:          11.303666ms
max:             328.434125ms
95th percentile: 22.95579ms
99th percentile: 41.21401ms

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Apr 11, 2022
@codyoss codyoss changed the title loadtest support app profile. feat(bigtable): loadtest support app profile Apr 11, 2022
@codyoss
Copy link
Member

codyoss commented Apr 11, 2022

Hey @stephennancekivell would you please mind opening up a corresponding issue for discussion about adding this feature. Thanks.

@stephennancekivell stephennancekivell mentioned this pull request Apr 11, 2022
Closed
@stephennancekivell
Copy link
Contributor Author

Hi @codyoss, sure thing. #5883

@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Apr 12, 2022
@telpirion telpirion added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 14, 2022
@telpirion telpirion added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 2, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 2, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit ec00e5a into googleapis:main May 2, 2022
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 2, 2022
@release-please release-please bot mentioned this pull request May 2, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request May 26, 2022
@release-please
chore(main): release bigtable 1.14.0 (#5614)
a00d00d 
🤖 I have created a release *beep* *boop*
---


## [1.14.0](bigtable/v1.13.0...bigtable/v1.14.0) (2022-05-26)


### Features

* **bigtable:** add file for tracking version ([17b36ea](17b36ea))
* **bigtable:** loadtest support app profile ([#5882](#5882)) ([ec00e5a](ec00e5a))
* **bigtable:** support PingAndWarm in emulator ([#5803](#5803)) ([9b943d5](9b943d5))


### Bug Fixes

* **bigtable:** use internal.Version that is auto-updated for UA ([#5679](#5679)) ([bd2c600](bd2c600)), refs [#3330](#3330)

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@release-please release-please bot mentioned this pull request May 26, 2022
Merged
@stephennancekivell stephennancekivell deleted the loadtest-support-app-profile branch July 8, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@telpirion telpirion telpirion approved these changes

@dmahugh dmahugh Awaiting requested review from dmahugh

@tritone tritone Awaiting requested review from tritone

Assignees
No one assigned
Labels
api: bigtable Issues related to the Bigtable API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephennancekivell @codyoss @telpirion @kokoro-team