Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use AuthMetadataPlugin with context manager #460

Closed
wants to merge 2 commits into from

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Mar 16, 2020

If this is merged, google-api-core will have to be modified to make use of the context manager.

@lidiz @gnossen Does this look reasonable?

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 16, 2020
@gnossen
Copy link

gnossen commented Mar 16, 2020

@busunkim96 There are also currently no hooks in gRPC to call your __enter__ and __exit__ methods. We've have to make changes to the gRPC Python-level creds API to make this work. What memory leak remains after #461? If the creds objects are not being garbage collected ever, then there's likely a reference cycle issue that needs to be addressed.

@busunkim96 busunkim96 closed this Mar 19, 2020
@tseaver tseaver deleted the use-context-manager branch October 28, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants