Skip to content
This repository has been archived by the owner on Jun 24, 2024. It is now read-only.

feat: support apiEndpoint override #230

Merged
merged 1 commit into from
Jun 17, 2019
Merged

feat: support apiEndpoint override #230

merged 1 commit into from
Jun 17, 2019

Conversation

JustinBeckwith
Copy link
Contributor

This does a few things:

  • Adds the apiEndpoint config option, making it overridable
  • Updates the default endpoint to use storage.googleapis.com
  • Swaps out nyc for c8 since coverage appeared to be broken

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 16, 2019
@JustinBeckwith JustinBeckwith mentioned this pull request Jun 16, 2019
Closed
51 tasks
bcoe
bcoe approved these changes Jun 17, 2019
View reviewed changes
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@JustinBeckwith JustinBeckwith merged commit 41325ac into master Jun 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bcoe bcoe bcoe approved these changes

@stephenplusplus stephenplusplus Awaiting requested review from stephenplusplus

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JustinBeckwith @bcoe @googlebot