Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): handle space in non-devel go version #288

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

noahdietz
Copy link
Contributor

Some development Go runtime versions do not use the devel + prefix that goVersion already accounted for. To handle this, if it is non-devel (as already defined) and has spaces, we trim everything after the first space, which should be the Go version we want to report.

@noahdietz noahdietz requested a review from a team as a code owner June 13, 2023 20:10
@noahdietz noahdietz merged commit fd7bca0 into googleapis:main Jun 13, 2023
@noahdietz noahdietz deleted the fix-go-version branch June 13, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants