APIError.Error() nil pointer exception in some cases.

[hime]

I'm curious if getting a nil pointer exception when trying to get string version of APIError (using .Error()) documented. The issue arises when we attempt to run operations on the wrapped error field APIError.err. We are able to safely created using the ParseError. However, when we call .Error() method on this error, we call APIError.err.Error() without checking if err field was set.

Environment details

• Package version: gax-go/v2 v2.12.3

Steps to reproduce

1. Create API Error using ParseError
2. Call (APIError).Error() on error.

Making sure to follow these steps will guarantee the quickest resolution possible.

Thanks!

[quartzmo]

Hi @hime,

Please provide a complete code example reproducing the issue you encountered, along with the expected output when running your example. Thanks!

[hime]

Hi @quartzmo,

Here's a code example. Regarding the expected output, maybe we can leave the message unset if error is nil.

Code

// You can edit this code!
// Click here and start typing
package main

import (
	"fmt"

	"github.com/googleapis/gax-go/v2/apierror"
	"google.golang.org/grpc/status"
)

func main() {
	err := status.New(500, "internal error").Err()
	apiErr, _ := apierror.ParseError(err, false)
	fmt.Println("Our error: ", apiErr.Error())
}

Output

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0x79e415]

goroutine 1 [running]:
github.com/googleapis/gax-go/v2/apierror.(*APIError).Error(0xc0001ae090)
   .../vendor/github.com/googleapis/gax-go/v2/apierror/apierror.go:210 +0x35
main.main()
   .../example.go:16 +0xd3
exit status 2

[quartzmo]

@hime Thanks for the quick reply. I reproduced the issue using your code example. I need to do some investigation into what the expected behavior is when the second wrap argument to ParseError is false. Thank you very much for reporting this bug.