Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable TS smoke test job #915

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Re-enable TS smoke test job #915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/sync-repo-settings.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ branchProtectionRules:
- 'tests'
- 'probes'
- 'protobufjs-load-test'
- 'typescript-smoke-test'
- 'cla/google'
requiredApprovingReviewCount: 1
requiresCodeOwnerReviews: true
Expand Down
41 changes: 20 additions & 21 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,27 +139,26 @@ jobs:
echo "gRPC exit code: $GRPC_EXIT_CODE"
echo "REST status code: $STATUSCODE"
[ $STATUSCODE = "200" ] && [ GRPC_EXIT_CODE != 0 ]
# Disabled until https://github.com/googleapis/gapic-generator-typescript/pull/955 is merged/released.
# typescript-smoke-test:
# runs-on: ubuntu-latest
# steps:
# - uses: actions/checkout@v2
# - uses: actions/setup-node@v2
# with:
# node-version: '12'
# - name: Run gapic-generator-typescript
# run: |
# mkdir tsout
# docker run --rm --user $UID \
# --mount type=bind,source="$(pwd)"/schema,destination=/in/protos/google/showcase/v1beta1,readonly \
# --mount type=bind,source="$(pwd)"/tsout,destination=/out/ \
# gcr.io/gapic-images/gapic-generator-typescript:latest
# - name: Run auto-generated tests
# run: |
# cd tsout
# npm install
# npm test
# npm run system-test
typescript-smoke-test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: '12'
- name: Run gapic-generator-typescript
run: |
mkdir tsout
docker run --rm --user $UID \
--mount type=bind,source="$(pwd)"/schema,destination=/in/protos/google/showcase/v1beta1,readonly \
--mount type=bind,source="$(pwd)"/tsout,destination=/out/ \
gcr.io/gapic-images/gapic-generator-typescript:latest
- name: Run auto-generated tests
run: |
cd tsout
npm install
npm test
npm run system-test
protobufjs-load-test:
runs-on: ubuntu-latest
steps:
Expand Down