fix: fix log messages and ignore falsey env vars #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #724 +/- ##
==========================================
+ Coverage 90.74% 90.76% +0.02%
==========================================
Files 28 28
Lines 1491 1495 +4
Branches 294 296 +2
==========================================
+ Hits 1353 1357 +4
Misses 59 59
Partials 79 79
Continue to review full report at Codecov.
|
kjin
changed the title
jinwoo
approved these changes
Apr 16, 2018
src/index.ts
Outdated
| @@ -69,16 +69,18 @@ function initConfig(projectConfig: Forceable<Config>): | |||
| Forceable<NormalizedConfig> { | |||
| const envConfig = { | |||
| logLevel: Number(process.env.GCLOUD_TRACE_LOGLEVEL) || undefined, | |||
| projectId: process.env.GCLOUD_PROJECT, | |||
| projectId: process.env.GCLOUD_PROJECT || undefined, | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Node 6 CI passes despite failure output (which is due to this PR not being rebased on #723) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change causes the Trace Agent to now ignore empty string environmental variables. Formerly,
would initialize the
projectIdfield to an empty string.This change also fixes a few log message contents, and adds two info-level log messages for when new spans are created.