New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring tests #415

Merged

fiboknacky merged 1 commit into googleads:master from carusogabriel:refactoring-tests

Dec 13, 2017

Contributor

carusogabriel commented Dec 7, 2017

I've refactored some tests, using:

PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase (see Use PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase #396);
assertCount instead of count function;
assertNotFalse instead of strict comparison !== with false keyword;
assertStringEqualsFile instead of file_get_contents function.


          Refactoring tests

b1c09e4

Member

fiboknacky commented Dec 13, 2017

Thanks for contribution.

fiboknacky merged commit 676b722 into googleads:master

carusogabriel deleted the refactoring-tests branch

December 13, 2017 20:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet