Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[derive] Test with trivial_bounds feature #515

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 84 additions & 0 deletions zerocopy-derive/tests/ui-nightly/trivial_bounds.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,84 @@
// Copyright 2023 The Fuchsia Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#![feature(trivial_bounds)]

extern crate zerocopy;

#[path = "../util.rs"]
mod util;

use static_assertions::assert_impl_all;
use zerocopy::{AsBytes, FromBytes, FromZeroes, Unaligned};

use self::util::{NotZerocopy, AU16};

fn main() {}

// These tests are compiled with the `trivial_bounds` feature enabled. We emit
// code which is designed to fail compilation for types we wish to reject. E.g.:
//
// #[derive(FromZeroes)]
// struct Foo(NotZerocopy);
//
// It would be unsound to emit an impl of `FromZeroes for Foo` in this case. Our
// custom derives are designed to cause compilation to fail for this type.
// `trivial_bounds` instead allows this code to succeed by simply not emitting
// `impl FromZeroes for Foo`. This isn't a soundness issue, but is likely
// confusing to users.
//
// As of this writing, the code in this file only fails to compile thanks to the
// use of `assert_impl_all!`, which depends upon the incorrect trait bounds.
//
// TODO(https://github.com/rust-lang/rust/issues/48214): If support is ever
// added for `#[deny(trivially_false_bounds)]` as discussed in the
// `trivial_bounds` tracking issue, we should emit that annotation in our
// derives. That will result in the `#[derive(...)]` annotations in this file
// failing to compile, not just the `assert_impl_all!` calls.

//
// FromZeroes errors
//

#[derive(FromZeroes)]
struct FromZeroes1 {
value: NotZerocopy,
}

assert_impl_all!(FromZeroes1: FromZeroes);

//
// FromBytes errors
//

#[derive(FromBytes)]
struct FromBytes1 {
value: NotZerocopy,
}

assert_impl_all!(FromBytes1: FromBytes);

//
// AsBytes errors
//

#[derive(AsBytes)]
#[repr(C)]
struct AsBytes1 {
value: NotZerocopy,
}

assert_impl_all!(AsBytes1: AsBytes);

//
// Unaligned errors
//

#[derive(Unaligned)]
#[repr(C)]
struct Unaligned1 {
aligned: AU16,
}

assert_impl_all!(Unaligned1: Unaligned);
22 changes: 22 additions & 0 deletions zerocopy-derive/tests/ui-nightly/trivial_bounds.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
error[E0277]: the trait bound `FromBytes1: FromZeroes` is not satisfied
--> tests/ui-nightly/trivial_bounds.rs:55:10
|
55 | #[derive(FromBytes)]
| ^^^^^^^^^ the trait `FromZeroes` is not implemented for `FromBytes1`
|
= help: the following other types implement trait `FromZeroes`:
bool
char
isize
i8
i16
i32
i64
i128
and $N others
note: required by a bound in `FromBytes`
--> $WORKSPACE/src/lib.rs
|
| pub unsafe trait FromBytes: FromZeroes {
| ^^^^^^^^^^ required by this bound in `FromBytes`
= note: this error originates in the derive macro `FromBytes` (in Nightly builds, run with -Z macro-backtrace for more info)