Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable GitHub merge queue #344

Closed
jswrenn opened this issue Sep 7, 2023 · 1 comment · Fixed by #428
Closed

Enable GitHub merge queue #344

jswrenn opened this issue Sep 7, 2023 · 1 comment · Fixed by #428
Labels
compatibility-nonbreaking Changes that are (likely to be) non-breaking experience-easy This issue is easy, and shouldn't require much experience help wanted Extra attention is needed

Comments

@jswrenn
Copy link
Collaborator

jswrenn commented Sep 7, 2023

Enable the Github merge queue. Merge queues prevent semantic conflicts, thus providing an additional safeguard against breaking the main branch.
@joshlf
Copy link
Member

joshlf commented Sep 7, 2023

Woah, didn't know about this! Absolutely.

Looks like we need to update our CI to support it first:

Screenshot 2023-09-07 at 9 18 59 AM

Feel free to put up a PR. If not, I'll take a stab at this at some point.

@joshlf joshlf added help wanted Extra attention is needed experience-easy This issue is easy, and shouldn't require much experience compatibility-nonbreaking Changes that are (likely to be) non-breaking labels Sep 7, 2023
jswrenn added a commit that referenced this issue Sep 29, 2023
@jswrenn
[ci] configure CI to support merge queue
6a06f04 
Fixes #344.
@jswrenn jswrenn mentioned this issue Sep 29, 2023
Merged
joshlf pushed a commit that referenced this issue Sep 29, 2023
@jswrenn
[ci] Configure CI to support merge queue (#428)
b083f1f 
Fixes #344
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility-nonbreaking Changes that are (likely to be) non-breaking experience-easy This issue is easy, and shouldn't require much experience help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ci] configure CI to support merge queue google/zerocopy
2 participants
@joshlf @jswrenn