Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored file jsguide.js #793

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

khaidao000
Copy link

Refactoring includes:

Using querySelector for simplicity where possible.
Utilizing Array.prototype.forEach.call to directly iterate over NodeList.
Utilizing const for variable declarations where possible.
Simplifying if conditions.
Grouping similar logic and segregating different logic with line breaks for readability.

@google-cla
Copy link

google-cla bot commented Sep 28, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Member

@vapier vapier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please break this up into multiple changes. there's good stuff in here, but squashing all of this rewrite into a single commit makes it difficult/impossible to reasonably review, and makes it hard to detect bugs or unintentional changes in behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants