Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sphericaltools v2 #155

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Sphericaltools v2 #155

wants to merge 6 commits into from

Conversation

kodawah
Copy link
Contributor

@kodawah kodawah commented Feb 27, 2017

This PR removes any v1 reference and adds support for v2 spherical videos.
Not my best python code, but it should get the job done.
Let me know what you think.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@Boscop
Copy link

Boscop commented Jun 19, 2020

Any update on this?

@kodawah
Copy link
Contributor Author

kodawah commented Jun 19, 2020

¯\_(ツ)_/¯

@Boscop
Copy link

Boscop commented Jun 19, 2020

@kodabb I think the bot is waiting for you to sign the Contributor License Agreement and then reply I signed it! :)

@kodawah
Copy link
Contributor Author

kodawah commented Jun 19, 2020

@Boscop there is already code from me in master f6bf328

half the spec was written with a collaboration of facebook, youtube and vimeo, I don't think there is a need to be overly formal here

@Boscop
Copy link

Boscop commented Jun 20, 2020

@kodabb But the bot doesn't know it. Just write I signed it! and see what the bot responds, otherwise this will be stuck forever :/

@kodawah
Copy link
Contributor Author

kodawah commented Jun 20, 2020

@Boscop unfortunately i don't have time to resolve the conflicts, and my branch serves my usecase pretty well. Plus CLAs are stupid.

You have my permission to update it and go in the process of having it merged if you so desire

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants