Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native go fuzzing: Restrict fuzzer lookup to *.go #8238

Merged
merged 1 commit into from
Aug 17, 2022
Merged

native go fuzzing: Restrict fuzzer lookup to *.go #8238

merged 1 commit into from
Aug 17, 2022

Conversation

pjbgf
Copy link
Contributor

@pjbgf pjbgf commented Aug 13, 2022

Projects containing words starting with Fuzz in non-go files break compile_native_go_fuzzer with the error:

sed: -e expression #1, char 15: unknown option to 's'

Copy link
Collaborator

@AdamKorcz AdamKorcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pjbgf
Copy link
Contributor Author

pjbgf commented Aug 15, 2022

The infra tests failure seems to be orthogonal to the changes in this PR. I will rebase with the latest to kick-off a retry.

@Navidem
Copy link
Contributor

Navidem commented Aug 15, 2022

I will rebase with the latest to kick-off a retry.

Looks still failing?

@pjbgf
Copy link
Contributor Author

pjbgf commented Aug 15, 2022

Yes, I tested the same version of the code base without my changes and the error was still there.

I wonder whether something broke that test since the last time it passed. The last successful run was triggered by the sort_index branch being merged: https://github.com/google/oss-fuzz/actions/workflows/infra_tests.yml.

Comparing the changes since last pass I could not find anything I could point out as the issue. But I am not very familiar with the code base, so any help would be greatly appreciated.

@Navidem
Copy link
Contributor

Navidem commented Aug 15, 2022

The failure does not seem related to your change, it is from our infra:
https://github.com/google/oss-fuzz/runs/7834055737?check_suite_focus=true#step:9:873

Let's see how trial_build goes.

@Navidem
Copy link
Contributor

Navidem commented Aug 15, 2022

/gcbrun trial_build.py smt helm --sanitizer address --fuzzing-engine libfuzzer

Projects containing words starting with Fuzz in non-go
files break compile_native_go_fuzzer with the error:
sed: -e expression #1, char 15: unknown option to 's'

Signed-off-by: Paulo Gomes <pjbgf@linux.com>
@Navidem
Copy link
Contributor

Navidem commented Aug 17, 2022

Merging this as the trial_build failure is irrelevant.

@Navidem
Copy link
Contributor

Navidem commented Aug 17, 2022

Merging this as the trial_build failure is irrelevant.

Actually not yet!
Project tests / build (afl, address, x86_64) test failed -- as a timeout. Waiting for the re-run.

@Navidem
Copy link
Contributor

Navidem commented Aug 17, 2022

Merging this as the trial_build failure is irrelevant.

Actually not yet! Project tests / build (afl, address, x86_64) test failed -- as a timeout. Waiting for the re-run.

Passed!

@Navidem Navidem merged commit 0b416da into google:master Aug 17, 2022
@pjbgf pjbgf deleted the flux-update branch August 17, 2022 07:00
@pjbgf
Copy link
Contributor Author

pjbgf commented Aug 17, 2022

@Navidem thank you for pushing this through. 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants