Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: workaround new requirement to use common-main #7818

Merged
merged 1 commit into from
Jul 16, 2022

Commits on Jul 15, 2022

  1. git: workaround new requirement to use common-main

    Due to upstream changes, the Git fuzzers must now link against
    common-main.o; however, this breaks the build in two ways:
    
    1) Linking with common-main.o causes main() to have multiple
    definitions, one in common-main.o and one from the fuzzing engine.
    
    2) To avoid google#1, the Git Makefile specifically excludes common-main.o
    from the fuzzer build rule.
    
    To work around these issues, we can override FUZZ_CXXFLAGS (add
    "-Wl,--allow-multiple-definition" to fix google#1) and LIB_FUZZING_ENGINE (add
    "common-main.o" to fix google#2).
    
    Once we can get a Makefile fix into Git's upstream, we can remove the
    override for LIB_FUZZING_ENGINE.
    
    However, this change causes `check_build` to fail for honggfuzz, and we
    have not yet been able to diagnose the reason. So for now, we also need
    to limit our engines to afl and libfuzzer.
    steadmon committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    85b2f29 View commit details
    Browse the repository at this point in the history