[qt] Clone the latest combination of qtbase and qtsvg which passed upstream CI #7017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qtsvg/depencies.yaml contains the latest revision of qtbase which qtsvg was successfully tested with. This is usually much newer than the submodules in qt5.
|
afl-clang-fast++ crashing again. Is anybody already working on that? Should be unrelated to this change. |
Hoping that recent afl revert fixes the build.
|
Building Qt passed in #7028 , which did not build Qt Widgets. In case that made the difference, I'll try another run of this here when https://codereview.qt-project.org/c/qt/qtqa/+/386883 was merged upstream, the change which was cherry-picked into #7028. |
|
Could someone please merge this? Because of problems on Qt's (our) side, the tested code is more than a month old already. This change here allow us to circumvent that. Should anything be missing in the change, please let me know and I'll fix it. |
DavidKorczynski
approved these changes
Dec 20, 2021
|
Oh, that was quick! Thank you very much. :-) |
You're welcome :)! |
MartinPetkov
pushed a commit
to MartinPetkov/oss-fuzz
that referenced
this pull request
Aug 15, 2022
…stream CI (google#7017) * [qt] Clone sources according to qtsvg's latest dependencies qtsvg/depencies.yaml contains the latest revision of qtbase which qtsvg was successfully tested with. This is usually much newer than the submodules in qt5. * [qt] Still keep the old source checkout * Empty commit to trigger github actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The super-repo qt5.git contains the revisions which were last tested successfully with all
submodules together. That is much older.
The super repo can be removed as soon as the build script was updated in upstream repo.