Add libtpms project

[elmarco]

This requires stefanberger/libtpms#37

Then hopefully, it should work.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[inferno-chromium]

@elmarco - seeing some weird failures. Any ideas ?

I  ERROR: build step 20 "gcr.io/oss-fuzz/libtpms" failed: exit status 2 
I  ERROR 
I  Finished Step #20 
I  Step #20: make: Leaving directory '/work/build/tests' 
I  Step #20: Makefile:654: recipe for target 'fuzz' failed 
I  Step #20: make: *** [fuzz] Error 1 
I  Step #20: clang-9: error: linker command failed with exit code 1 (use -v to see invocation) 
I  Step #20: `.text.sancov.module_ctor.8' referenced in section `.init_array.2[sancov.module_ctor.8]' of /work/build/src/.libs/libtpms.a(libtpms_tpm2_la-PropertyCap.o): defined in discarded section `.text.sancov.module_ctor.8[sancov.module_ctor]' of /work/build/src/.libs/libtpms.a(libtpms_tpm2_la-PropertyCap.o) 
I  Step #20: `.text.sancov.module_ctor.18' referenced in section `.init_array.2[sancov.module_ctor.18]' of /work/build/src/.libs/libtpms.a(libtpms_tpm2_la-AsymmetricCommands.o): defined in discarded section `.text.sancov.module_ctor.18[sancov.module_ctor]' of /work/build/src/.libs/libtpms.a(libtpms_tpm2_la-AsymmetricCommands.o) 
I  Step #20: `.text.sancov.module_ctor.43' referenced in section `.init_array.2[sancov.module_ctor.43]' of /work/build/src/.libs/libtpms.a(libtpms_tpm2_la-NVCommands.o): defined in discarded section `.text.sancov.module_ctor.43[sancov.module_ctor]' of /work/build/src/.libs/libtpms.a(libtpms_tpm2_la-NVCommands.o) 
I  Step #20: `.text.sancov.module_ctor.41' referenced in section `.init_array.2[sancov.module_ctor.41]' of /work/build/src/.libs/libtpms.a(libtpms_tpm2_la-CryptEccSignature.o): defined in discarded section `.text.sancov.module_ctor.41[sancov.module_ctor]' of /work/build/src/.libs/libtpms.a(libtpms_tpm2_la-CryptEccSignature.o) 
I  Step #20: `.text.sancov.module_ctor.10' referenced in section `.init_array.2[sancov.module_ctor.10]' of /work/build/src/.libs/libtpms.a(libtpms_tpm2_la-CryptCmac.o): defined in discarded section `.text.sancov.module_ctor.10[sancov.module_ctor]' of /work/build/src/.libs/libtpms.a(libtpms_tpm2_la-CryptCmac.o) 
I  Step #20: `.text.sancov.module_ctor.66' referenced in section `.init_array.2[sancov.module_ctor.66]' of /work/build/src/.libs/libtpms.a(libtpms_tpm2_la-BnMath.o): defined in discarded section `.text.sancov.module_ctor.66[sancov.module_ctor]' of /work/build/src/.libs/libtpms.a(libtpms_tpm2_la-BnMath.o) 
I  Step #20: `.text.sancov.module_ctor.55' referenced in section `.init_array.2[sancov.module_ctor.55]' of /work/build/src/.libs/libtpms.a(libtpms_tpm2_la-AlgorithmTests.o): defined in discarded section `.text.sancov.module_ctor.55[sancov.module_ctor]' of /work/build/src/.libs/libtpms.a(libtpms_tpm2_la-AlgorithmTests.o) 

I also see

I  Step #20: grep: tpm2/PP.c: No such file or directory 
I  Step #20: grep: tpm2/PowerPlat.c: No such file or directory 
I  Step #20: grep: tpm2/Power.c: No such file or directory 

I think something on builder is different from infra/helper.py. @oliverchang can help but is OOO this week.

[elmarco]

@inferno-chromium thanks for the report, I have no idea why the link fails. Is there a full build log I can access? It would be nice if I can have a reproducer with infra/helper.py.

The grep errors are from upstream, and can be ignored for now (we should solve them eventually)

thanks

[inferno-chromium]

Actually my last comment was wrong. Firstly logs are unavailable/not updated due #2263 (should be fixed end of week).
And secondly fuzzing build is all ok, so fuzzing is happening. What is broken is the coverage build (wont block fuzzing)

weirdly python infra/helper.py build_fuzzers --sanitizer coverage libtpms
is not reproducing this. @Dor1s - any ideas why flags show up trace-pc-guard

Step #20: /bin/bash ../libtool --tag=CC --mode=link clang -fsanitize=fuzzer -I/src/libtpms/include -O1 -fno-omit-frame-pointer -gline-tables-only -DFUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION -fsanitize=address -fsanitize-address-use-after-scope -fsanitize-coverage=trace-pc-guard -Wall -Werror -Wreturn-type -Wsign-compare -Wno-self-assign -fsanitize=fuzzer -ltpms -L../src/.libs -o fuzz fuzz-fuzz.o -lcrypto

[Dor1s]

It's not coverage build, I believe. The compilation flags look totally wrong, e.g. -fsanitize=fuzzer -- where it comes from? We don't use it, we use -fsanitize=fuzzer-no-link. I think it's AFL + AddressSanitizer configuration. There's where -fsanitize-coverage=trace-pc-guard is used. Should be reproducible locally via:

python infra/helper.py build_fuzzers --engine afl --sanitizer address $project_name

[Dor1s]

-fsanitize=fuzzer likely comes from here: https://github.com/stefanberger/libtpms/blob/db5af633925097284ded2b00907bdd6818390de2/tests/Makefile.am#L28

When building on OSS-Fuzz, the projects should use the provided CFLAGS and CXXFLAGS and don't append any extra sanitization / fuzzing flags.

[inferno-chromium]

Thanks a lot @Dor1s for awesome debugging. I missed the AFL fact, so this is a AFL build failure and not coverage one. @elmarco can you please remove the -fsanitize=fuzzer override as per @Dor1s last comment and recheck that AFL build works. Thanks!

[elmarco]

@Dor1s @inferno-chromium stefanberger/libtpms@b214dab should fix the issues.

[Dor1s]

Awesome! I see that two recent builds have succeeded. Thank you, @elmarco,