Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure up-to-date dependencies for Capstone Python bindings #12317

Merged
merged 6 commits into from
Aug 11, 2024

Conversation

kabeor
Copy link
Contributor

@kabeor kabeor commented Aug 8, 2024

The base-builder-python docker image installs setuptools v42.0. This is very likely the reason why Capstone's setup.py fails.

@DavidKorczynski Is there any reason why it is set to this (very old) version? The docs recommend this one.

Copy link

github-actions bot commented Aug 8, 2024

kabeor is either the primary contact or is in the CCs list of projects/capstone.
kabeor has previously contributed to projects/capstone. The previous PR was #10556

@DaveLak
Copy link
Contributor

DaveLak commented Aug 10, 2024

Is there any reason why it is set to this (very old) version? The docs recommend this one.

I'm a different David than the one you asked but I think I can answer the question:

Likely because upgrading it impacts every integrated Python project and it's somewhat time consuming to:

  • verify the change doesn't introduce new build failures.
  • the debug & patch any new failures that do get introduced by the upgrade.

I've been keen on seeing this bumped as well, but last I checked a few months ago, there were a few projects that required patches to prevent new failures.

I was planning on trying to upgrade setuptools and pyinstaller after upgrading Python to 3.10 in #12027 (if I'm able to get that landed) since it will enable the removal of a lot of adhoc workarounds that many Python projects are currently employing which would hopefully make a dependency upgrade simpler to manage.

@kabeor
Copy link
Contributor Author

kabeor commented Aug 11, 2024

@DaveLak Thank you very much for your help, I guess we finally solved this by upgrading pip.

Please ignore the request for review below, I clicked the wrong one:)

@kabeor kabeor requested a review from DaveLak August 11, 2024 09:37
@kabeor
Copy link
Contributor Author

kabeor commented Aug 11, 2024

@DavidKorczynski Hi, it's ready to be merged, thanks:)

@DavidKorczynski DavidKorczynski merged commit eff24f7 into google:master Aug 11, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants