Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suricata: clean some disk space while building #11797

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

catenacyber
Copy link
Contributor

As done by openssl in #11618

Is there a way from build.sh to know if we are built by CIFuzz ? Like environment variable CFL_PLATFORM ?
Because I do not think we want to build other branches than master for CIFuzz

Copy link

catenacyber is either the primary contact or is in the CCs list of projects/suricata.
catenacyber has previously contributed to projects/suricata. The previous PR was #11230

Copy link
Contributor

@jonathanmetzman jonathanmetzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DavidKorczynski DavidKorczynski merged commit bd24713 into google:master Apr 11, 2024
16 checks passed
@jonathanmetzman
Copy link
Contributor

As done by openssl in #11618

Is there a way from build.sh to know if we are built by CIFuzz ? Like environment variable CFL_PLATFORM ? Because I do not think we want to build other branches than master for CIFuzz

There is, let me get it for you

@catenacyber
Copy link
Contributor Author

As done by openssl in #11618
Is there a way from build.sh to know if we are built by CIFuzz ? Like environment variable CFL_PLATFORM ? Because I do not think we want to build other branches than master for CIFuzz

There is, let me get it for you

@jonathanmetzman did you find it ?

@kleisauke
Copy link
Contributor

Is there a way from build.sh to know if we are built by CIFuzz ? Like environment variable CFL_PLATFORM ?

You can use the CIFUZZ environment variable for this.

'-e', 'FUZZING_ENGINE=' + constants.DEFAULT_ENGINE, '-e', 'CIFUZZ=True'

@catenacyber
Copy link
Contributor Author

Thanks @kleisauke cf #11800

catenacyber added a commit to catenacyber/oss-fuzz that referenced this pull request Apr 14, 2024
@catenacyber
Copy link
Contributor Author

This seems to have broken coverage build despite green CI cf https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=68045

make clean removes some generated code files like `gen/rust-bindings.h' so we get

Step #5: �[0m�[0;31merror: /workspace/out/libfuzzer-coverage-x86_64/src/suricata7/rust/gen/rust-bindings.h: No such file or directory

Fix pushed in #11800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants