Interpret a blob of memory as a rar file for fuzzing. #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use the in-memory representation of the file
alex
reviewed
Jan 18, 2018
|
|
||
| std::unique_ptr<CommandData> cmd_data(new CommandData); | ||
| cmd_data->ParseArg(const_cast<wchar_t *>(L"-p")); | ||
| cmd_data->ParseArg(const_cast<wchar_t *>(L"x")); | ||
| cmd_data->ParseDone(); | ||
| std::wstring wide_filename(filename.begin(), filename.end()); | ||
| cmd_data->SetArcInMem(const_cast<unsigned char *>(data), size); | ||
| cmd_data->AddArcName(wide_filename.c_str()); |
There was a problem hiding this comment.
Can the filename be entirely removed now, or is it still required?
There was a problem hiding this comment.
Unfortunately, it is still required. Once we decide that we are definitely going down this path (in-memory), I can convince the maintainer to support it better i.e. not have to set filename at all,
There was a problem hiding this comment.
Does filename have to be unique, otherwise, we can just set it to a default like temp.rar ?
There was a problem hiding this comment.
It doesn't have to be but I agree that having a fixed name now is possible and faster so let me change that.
* Use the in-memory representation of the file * Use a fixed filename, skip calling getpid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is experimental but is expected to increase fuzzing speed.
I am going to run with this configuration for 1 week and then compare the performance from previous week to see if it is worth doing this.
For more discussion, see #951