Hide useless logs and add useful ones #31
Conversation
Use "" to prevent globbing and work splitting
| @@ -354,7 +354,11 @@ def build_and_run(self, generated_project: str, target_path: str, | |||
| check=True, | |||
| cwd=oss_fuzz_checkout.OSS_FUZZ_DIR) | |||
| except sp.CalledProcessError as e: | |||
| print('Failed to evaluate target on cloud:', e.stdout, e.stderr) | |||
| print(f'Failed to evaluate {os.path.realpath(target_path)} on cloud:', | |||
There was a problem hiding this comment.
Should we migrate to logging.info,debug etc in a future PR?
There was a problem hiding this comment.
Yes!
Created #34.
| mkdir results-report | ||
| cd results-report | ||
| # Spin up the web server generating the report (and bg the process). | ||
| PYTHONPATH=. /venv/bin/python3 report/web.py "${RESULTS_DIR:?}" "${WEB_PORT:?}" & |
There was a problem hiding this comment.
Can be for another PR: Can we replace the PYTHONPATH invocation here?
Also one other thing, it's hard to use this script locally because the local venv path may be different. Can we instead just have this invoke python3 by default, and allow this to be overridden by e.g. PYTHON for infra usages?
There was a problem hiding this comment.
Can be for another PR: Can we replace the PYTHONPATH invocation here?
Yes, let me create another PR for this.
it's hard to use this script locally because the local venv path may be different. Can we instead just have this invoke python3 by default, and allow this to be overridden by e.g. PYTHON for infra usages?
Yep, good point!
I will address this in a separate PR.
Hide numerous download progress logs from
wget2andgsutil.Add logs for cloud experiments to look for anomalies.