Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback custom constant value evaluator #2096

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

ting-yuan
Copy link
Collaborator

Use FIR's implementation instead.

Test case is derived from kuanyingchou@28add76

Fixes #2077

Use FIR's implementation instead.
// kotlin.String
// kotlin.String
// kotlin.String
// java.lang.String
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given annotation class ExampleAnnotation(val value: kotlin.reflect.KClass<*> = java.lang.String::class), I think the old expected values are wrong.

Copy link
Collaborator

@kuanyingchou kuanyingchou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ting-yuan ting-yuan merged commit 446ed80 into google:main Sep 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[KSP2] default value is null for nested annotation
2 participants