Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KSP2] Not yet implemented: KSValueArgumentImpl.getParent #2049

Closed
kuanyingchou opened this issue Aug 22, 2024 · 0 comments · Fixed by #2050
Closed

[KSP2] Not yet implemented: KSValueArgumentImpl.getParent #2049

kuanyingchou opened this issue Aug 22, 2024 · 0 comments · Fixed by #2050
Milestone
2.1

Comments

@kuanyingchou
Copy link
Collaborator

Created the issue so it's easier to track.

Stacktrace:

Caused by: kotlin.NotImplementedError: An operation is not implemented: Not yet implemented
	at com.google.devtools.ksp.impl.symbol.kotlin.KSValueArgumentImpl.getParent(KSValueArgumentImpl.kt:49)
	at androidx.room.compiler.processing.compat.XConverters.toXProcessing(XConverters.kt:248)
	at androidx.room.compiler.processing.compat.XConvertersTest$annotationValues$1.invoke(XConvertersTest.kt:619)
	at androidx.room.compiler.processing.compat.XConvertersTest$annotationValues$1.invoke(XConvertersTest.kt:565)
	at androidx.room.compiler.processing.SyntheticProcessorImpl.runNextRound(SyntheticProcessor.kt:110)
	at androidx.room.compiler.processing.SyntheticProcessorImpl.postRound$room_compiler_processing_testing(SyntheticProcessor.kt:70)
	at androidx.room.compiler.processing.SyntheticKspProcessor.postRound(SyntheticKspProcessor.kt:39)
	at androidx.room.compiler.processing.ksp.KspBasicAnnotationProcessor.process(KspBasicAnnotationProcessor.kt:63)
	at com.google.devtools.ksp.impl.KotlinSymbolProcessing.execute(KotlinSymbolProcessing.kt:538)
	at androidx.room.compiler.processing.util.compiler.Ksp2Compilation.execute(Ksp2Compilation.kt:54)
...
@ting-yuan ting-yuan added this to the 2.1 milestone Aug 22, 2024
ansman added a commit to ansman/ksp that referenced this issue Aug 23, 2024
@ansman
Implement KSValueArgument.parent for the analysis API
6720815 
This fixes google#2049
@ansman ansman mentioned this issue Aug 23, 2024
Merged
ting-yuan pushed a commit that referenced this issue Aug 23, 2024
@ansman @ting-yuan
Implement KSValueArgument.parent for the analysis API
f84a7f0 
This fixes #2049
github-actions bot pushed a commit that referenced this issue Aug 23, 2024
@ansman
Implement KSValueArgument.parent for the analysis API
8a829bb 
This fixes #2049

(cherry picked from commit f84a7f0)
ansman added a commit to ansman/ksp that referenced this issue Aug 24, 2024
@ansman
Delete the ksp caches when the task is restored from cache
7d24fdb 
Without this change, the task's caches will be in an incorrect state and
the next incremental run can lead to compile errors.

Now the caches have been marked as local state and Gradle will remove
them when the task is restored from the build cache.

This fixes google#2049
@ansman ansman mentioned this issue Aug 24, 2024
Merged
ansman added a commit to ansman/ksp that referenced this issue Aug 24, 2024
@ansman
Delete the ksp caches when the task is restored from cache
69a98ec 
Without this change, the task's caches will be in an incorrect state and
the next incremental run can lead to compile errors.

Now the caches have been marked as local state and Gradle will remove
them when the task is restored from the build cache.

This fixes google#2049
github-actions bot pushed a commit that referenced this issue Sep 5, 2024
@ansman
Implement KSValueArgument.parent for the analysis API
1506cc1 
This fixes #2049

(cherry picked from commit f84a7f0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1
Development

Successfully merging a pull request may close this issue.

Implement KSValueArgument.parent for the analysis API ansman/ksp
2 participants
@kuanyingchou @ting-yuan