Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added binPrefix option, to support running via Bazel #653

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

dorfire
Copy link

@dorfire dorfire commented Jul 12, 2021

No description provided.

@richardbarrell-calvium
Copy link
Contributor

I have another pull request with a similar purpose at #654. Is there any chance that the change I proposed is suitable for the use-case that you have, please?

@dorfire
Copy link
Author

dorfire commented Jul 22, 2021 via email

@richardbarrell-calvium
Copy link
Contributor

Rats. I was hoping that it would be easy for Bazel users to arrange to add the eslint dir to $PATH.

@dorfire
Copy link
Author

dorfire commented Aug 26, 2021

ping @JustinBeckwith :)

@alexander-fenster
Copy link
Contributor

@dorfire It's been almost a year but here we go, let's finally merge it :) Would you mind signing the CLA so that we could accept your PR?

@tonycoco
Copy link
Contributor

I can help push this into a release if we can resolve the conflicts

@tonycoco
Copy link
Contributor

Not sure this change is necessary any longer. @dorfire can you comment on this being necessary still? Otherwise, will close out the PR as out of date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants