Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds EventType consts representing the X-Github-Event header values #3271

Closed
wants to merge 0 commits into from

Conversation

MaerF0x0
Copy link

What: for each of the mapped types in github/messages.go it adds a EventType const .

Why: This will help with doing code like

Notes:

  • Should be a non-breaking change, exporting many new symbols
  • Let me know if you'd rather making it a breaking change on the EventForType function
  • Also let me know if you'd like me to define type EventTyper interface{ EventType() EventType } and implement for each of the types
switch eventType {
  case github.EventTypeIssues:
      // stuff
   case github.EventTypeIssueComment, github.EventTypePullRequestReviewComment:
     // comment stuff
}

Copy link

google-cla bot commented Sep 19, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant