Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics/vocabulary: err check before Close() #425

Merged
merged 1 commit into from
Feb 29, 2024
Merged

metrics/vocabulary: err check before Close() #425

merged 1 commit into from
Feb 29, 2024

Conversation

alrs
Copy link
Contributor

@alrs alrs commented Dec 22, 2023

This ensures that a check of err happens before a deferred Close().

@alrs alrs requested a review from a team as a code owner December 22, 2023 11:50
@timburks timburks merged commit bf7795e into google:main Feb 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timburks timburks timburks approved these changes

@dongjiang1989 dongjiang1989 dongjiang1989 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alrs @timburks @dongjiang1989