Refactor IncompatilblyScopedBindingsValidator. #4470
Merged
+27
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
This CL refactors the code to have a single filter so that it's easier to see which bindings are being filtered and reported on. I've also switched to using `Collectors.groupingBy` which makes the stream flow better. RELNOTES=N/A PiperOrigin-RevId: 682031867
copybara-service
bot
force-pushed
the
test_673110053
branch
from
12a40a6
to
2489cd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor IncompatilblyScopedBindingsValidator.
This CL refactors the code to have a single filter so that it's easier to see which bindings are being filtered and reported on. I've also switched to using
Collectors.groupingBywhich makes the stream flow better.RELNOTES=N/A