Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to blang/semver/v4 v4.0.0 #3078

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Conversation

skitt
Copy link
Contributor

@skitt skitt commented Mar 11, 2022

This is the first version to be fully go-mod-compatible.

Signed-off-by: Stephen Kitt skitt@redhat.com

@google-cla
Copy link

google-cla bot commented Mar 11, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@k8s-ci-robot
Copy link
Collaborator

Hi @skitt. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@skitt
Copy link
Contributor Author

skitt commented Mar 14, 2022

I’ve been added to the CCLA, I don’t know what needs to be done to re-trigger the cla/google job.

@skitt skitt force-pushed the blang-semver-v4 branch 2 times, most recently from ec3e096 to 88f2ca1 Compare March 31, 2022 11:59
@skitt
Copy link
Contributor Author

skitt commented Nov 22, 2022

@dims this is related to a k8s bump which went in a while ago (kubernetes/kubernetes#108629), and would simplify the overall dependency tree in k8s.

@dims
Copy link
Collaborator

dims commented Nov 22, 2022

for the record, the diff is : blang/semver@v3.5.1...v4.0.0

@dims
Copy link
Collaborator

dims commented Dec 1, 2022

/ok-to-test

@skitt
Copy link
Contributor Author

skitt commented Jan 4, 2023

@dims do you know who I should ping to try to make progress on this?

@dims
Copy link
Collaborator

dims commented Jan 4, 2023

@skitt we should reach out to @bobbypage

@skitt
Copy link
Contributor Author

skitt commented Mar 3, 2023

@bobbypage any chance you could take a look at this?

@skitt
Copy link
Contributor Author

skitt commented Jun 23, 2023

@bobbypage, @iwankgb, any chance I could get this PR reviewed? It would help the k/k dependency tree.

This is the first version to be fully go-mod-compatible.

Signed-off-by: Stephen Kitt <skitt@redhat.com>
@iwankgb iwankgb merged commit ff9b5b6 into google:master Jun 26, 2023
13 checks passed
@skitt skitt deleted the blang-semver-v4 branch June 26, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants