-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to blang/semver/v4 v4.0.0 #3078
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
Hi @skitt. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I’ve been added to the CCLA, I don’t know what needs to be done to re-trigger the cla/google job. |
ec3e096
to
88f2ca1
Compare
88f2ca1
to
e8d947c
Compare
@dims this is related to a k8s bump which went in a while ago (kubernetes/kubernetes#108629), and would simplify the overall dependency tree in k8s. |
for the record, the diff is : blang/semver@v3.5.1...v4.0.0 |
e8d947c
to
a3897d8
Compare
/ok-to-test |
@dims do you know who I should ping to try to make progress on this? |
@skitt we should reach out to @bobbypage |
@bobbypage any chance you could take a look at this? |
@bobbypage, @iwankgb, any chance I could get this PR reviewed? It would help the |
This is the first version to be fully go-mod-compatible. Signed-off-by: Stephen Kitt <skitt@redhat.com>
This is the first version to be fully go-mod-compatible.
Signed-off-by: Stephen Kitt skitt@redhat.com