fix(tests): Enable --debug for test:compile:advanced; fix some errors (and demote the rest to warnings)
#5983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enable the --debug flag when running the buildAdvancedCompilationTest gulp task. * Remove partialAlias diagnostic group from `JSC_ERROR`, demoting JSC_PARTIAL_NAMESPACE to warning. Reverts "Revert 'fix(tests): Enable --debug for test:compile:advanced; fix some errors (google#5959)'".
rachel-fenichel
approved these changes
Mar 8, 2022
This was referenced Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Proposed Changes
--debugflag when running thebuildAdvancedCompilationTestgulp task.test/compile/main.jstogoog.module.goog.requires.@suppress"extra" requires needed for side effects.build_tasks.jsto not promoteJSC_PARTIAL_ALIASdiagnostics to errors (leave them as warnings).Behaviour Before Change
No (non-fatal) diagnostics would be emitted by the advanced compilation test.
Behaviour After Change
Ten
JSC_PARTIAL_ALIASwarnings are emitted (which ought to be investigated!), and additional warnings and errors will be emitted if there are problems with the code.Reason for Changes
ADVANCED_OPTIMIZATIONS.Test Coverage
npm testcompletes successfully (for real this time!)