Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update block dragger #4842

Merged
merged 5 commits into from
May 21, 2021
Merged

Conversation

alschmiedt
Copy link
Contributor

@alschmiedt alschmiedt commented May 20, 2021

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

Proposed Changes

  • Changes private --> protected
  • Changes package --> public
  • Formats the document using clang
  • Breaks up larger functions to make overriding easier
  • Renames block dragger methods to make them more generic in anticipation of a common i_dragger interface.

Documentation

Additional Information

Copy link
Contributor

@maribethb maribethb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are currently discussing offline how to handle the name changes... since this isn't going into develop right now I'm fine with however you choose to handle it, we should just make sure to revisit this conversation before merging to develop

I like the new functions! Makes it easier to read as well as override now

core/block_dragger.js Outdated Show resolved Hide resolved
@alschmiedt
Copy link
Contributor Author

I'm going to leave the names for right now so that we can get this in, but we can revisit next week.

@alschmiedt alschmiedt merged commit fd417a0 into google:block_drag May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants