fix: always rename caller to legal name #6014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
npm run formatandnpm run lintThe details
Resolves
#5971
Proposed Changes
Makes it so that when call blocks are created, if their name matches an existing procedure def, but they do not have the args to match that procedure def, a new def is created with a new name, and the callers name is changed to match.
Behavior Before Change
A new procedure would be created, but the caller would not be renamed to match it, so the program would end up in a broken state.
Behavior After Change
The caller is renamed to match the generated definition, so the program is legal.
Reason for Changes
Letting users accidentally make their programs invalid is bad.
Test Coverage
Tested on:
Documentation
N/A
Additional Information
Love it when my past self writes tests for my future self :D