It is possible to have a caller block inconsistent to its definition

[gpfernandezflorio]

Describe the bug

Taking a block from the trashcan allows you to have a caller block inconsistent to its definition.

To Reproduce

Steps to reproduce the behavior:

1. Create a procedure definition.
   
2. Create and delete a caller for that procedure
   
3. Add a parameter to the procedure
   
4. Open the trashcan and add the caller to the workspace
   

Expected behavior

Not sure. I guess the caller should mutate to be consistent to it's definition.
Another option could be that it renames to a new procedure.

Desktop (please complete the following information):

• OS: Windows 11
• Browser: Chrome v98.0.4758.102

[alschmiedt]

Thanks for reporting! I think the first option where the caller mutates makes the most sense to me (it is similar to what we do in the flyout). Just a heads up we are unlikely to get this out for the upcoming release in a couple of weeks, but we always accept PRs if you are interested in contributing : )

[BeksOmega]

I don't think this is a problem specific to the trashcan. It can also occur when you paste a copied caller into the workspace:
https://imgur.com/qywiPYR

Ideally the pasted block would mutate to match the procedure def, but callers don't save the UUID of the block definition, only the name, which can change, so that behavior isn't possible. I think the correct behavior is for the newly pasted caller to have its name change to match the generated procedure definition. I think would should be able to add that here.

[BeksOmega]

Closed by #6014