Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert the Workspace class to an ES6 class #5977

Merged
merged 6 commits into from
Mar 16, 2022

Conversation

BeksOmega
Copy link
Collaborator

The basics

  • I branched from develop
  • My pull request is against develop
  • My code follows the style guide

The details

Resolves

More work on #5860

Proposed Changes

Converts the workspace "class" to an ES6 class.

Should be no behavior changes 🤞

Reason for Changes

The long winding road to typescript

Test Coverage

All unit tests pass

Documentation

N/A

Additional Information

N/A

@BeksOmega BeksOmega requested a review from a team as a code owner March 3, 2022 22:25
@BeksOmega BeksOmega removed the request for review from NeilFraser March 10, 2022 23:34
@BeksOmega BeksOmega requested a review from cpcallen March 10, 2022 23:34
@BeksOmega BeksOmega removed the request for review from cpcallen March 15, 2022 18:52
@BeksOmega BeksOmega assigned gonfunko and unassigned cpcallen Mar 15, 2022
@BeksOmega BeksOmega requested a review from gonfunko March 15, 2022 18:52
Copy link
Contributor

@cpcallen cpcallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that I did not get to this earlier. I've added a few comments about the peripheral changes; I will review the changes to workspace.js tomorrow if @gonfunko hasn't beaten me to them.

core/gesture.js Show resolved Hide resolved
core/xml.js Show resolved Hide resolved
core/xml.js Show resolved Hide resolved
core/xml.js Show resolved Hide resolved
core/workspace.js Outdated Show resolved Hide resolved
@BeksOmega BeksOmega merged commit e2eaebe into google:develop Mar 16, 2022
@BeksOmega BeksOmega deleted the refact/workspace-es6-class branch April 5, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants