fix(blocks): correct the callType_ of procedures_defreturn
#5974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
cpcallen
approved these changes
Mar 3, 2022
There was a problem hiding this comment.
Oh, nice catch. This was totally my fault: when factoring out the common parts of the two blocks in PR #5736 I somehow failed to notice that they had different values. Thanks for spotting the problem and providing the correct fix!
cpcallen
changed the title
callType_ of procedures_defreturn
This was referenced Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
#5972
Proposed Changes
The field callType_ was defined as 'procedures_callnoreturn' in PROCEDURE_DEF_COMMON.
Now it is defined separately in procedures_defnoreturn and in procedures_defreturn so each one defines it's own value for it.
Behavior Before Change
As shown in #5972, when selecting the option to create a caller of a returning procedure, the result was a procedures_callnoreturn block.
Behavior After Change
Now a procedures_callreturn is created.
Reason for Changes
To fix the problem.
Test Coverage
Tested on:
Desktop Chrome v98.0.4758.102 (Windows 11)