Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong type of block created with context menu option "create 'do something'" #5972

Closed
gpfernandezflorio opened this issue Mar 3, 2022 · 2 comments · Fixed by #5974
Closed
Assignees
Labels
component: library blocks issue: bug Describes why the code or behaviour is wrong

Comments

@gpfernandezflorio
Copy link
Contributor

Describe the bug

The caller block created with the context menu option "create 'do something'" is always a "noreturn" no matters if the source block is a "defreturn" or a "defnoreturn"

To Reproduce

Steps to reproduce the behavior:

  1. Create a procedures_defreturn block.
    image
  2. Open the context menu and select "create 'do something'"
    image
  3. This is the result:
    image

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser: Chrome v98.0.4758.102

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

The problem is that both procedures_defnoreturn and procedures_defreturn have the field callType_ assigned with "procedures_callreturn". After changing it from the console, it works.
image

@cpcallen
Copy link
Contributor

cpcallen commented Mar 3, 2022

This is now fixed (and I've added what I believe are suitable lables), but I will leave for oncall to complete triage and close.

@alschmiedt alschmiedt removed the issue: triage Issues awaiting triage by a Blockly team member label Mar 3, 2022
@alschmiedt
Copy link
Contributor

Fixed in #5974

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: library blocks issue: bug Describes why the code or behaviour is wrong
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants