fix: Change the truthy tests of width and height in WorkspaceSvg.setC…

…achedParentSvgSize to actual comparisons with null so that zero value can be saved into the cache (#5997) fixes #5930 and possibly #5404
google · Mar 15, 2022 · fec44d9 · fec44d9
1 parent 9e1cda8
commit fec44d9
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/core/workspace_svg.js b/core/workspace_svg.js
@@ -1244,13 +1244,13 @@ class WorkspaceSvg extends Workspace {
    */
   setCachedParentSvgSize(width, height) {
     const svg = this.getParentSvg();
-    if (width) {
+    if (width != null) {
       this.cachedParentSvgSize_.width = width;
       // This is set to support the public (but deprecated) Blockly.svgSize
       // method.
       svg.cachedWidth_ = width;
     }
-    if (height) {
+    if (height != null) {
       this.cachedParentSvgSize_.height = height;
       // This is set to support the public (but deprecated) Blockly.svgSize
       // method.