Fix bug with updating cursor style in draggers

google · Jun 10, 2021 · 2dc2143 · 2dc2143
1 parent d2c61d5
commit 2dc2143
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/core/block_dragger.js b/core/block_dragger.js
@@ -217,12 +217,12 @@ Blockly.BlockDragger.prototype.dragBlock = function(e, currentDragDeltaXY) {
   }
 
   this.draggedConnectionManager_.update(delta, this.dragTarget_);
-  var wouldDeleteBlock = this.draggedConnectionManager_.wouldDeleteBlock();
-  if (wouldDeleteBlock != this.wouldDeleteBlock_) {
+  var oldWouldDeleteBlock = this.wouldDeleteBlock_;
+  this.wouldDeleteBlock_ = this.draggedConnectionManager_.wouldDeleteBlock();
+  if (oldWouldDeleteBlock != this.wouldDeleteBlock_) {
     // Prevent unnecessary add/remove class calls.
     this.updateCursorDuringBlockDrag_();
   }
-  this.wouldDeleteBlock_ = wouldDeleteBlock;
 };
 
 /**

diff --git a/core/bubble_dragger.js b/core/bubble_dragger.js
@@ -141,12 +141,12 @@ Blockly.BubbleDragger.prototype.dragBubble = function(e, currentDragDeltaXY) {
     this.dragTarget_ && this.dragTarget_.onDragEnter();
   }
 
-  var wouldDeleteBubble = this.shouldDelete_(this.dragTarget_);
-  if (wouldDeleteBubble != this.wouldDeleteBubble_) {
+  var oldWouldDeleteBubble = this.wouldDeleteBubble_;
+  this.wouldDeleteBubble_ = this.shouldDelete_(this.dragTarget_);
+  if (oldWouldDeleteBubble != this.wouldDeleteBubble_) {
     // Prevent unnecessary add/remove class calls.
     this.updateCursorDuringBubbleDrag_();
   }
-  this.wouldDeleteBubble_ = wouldDeleteBubble;
 };
 
 /**