Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a function to allow removing generators in the playground #765

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

joshcai
Copy link
Contributor

@joshcai joshcai commented Jun 15, 2021

This addresses: #739 - "RemoveGenerator function for playground"

This adds the "removeGenerator" function that allows users to hide generator tabs in the advanced playground.

I tested the change by manually bringing up the advanced_playground and adding these lines:

   playground.addGenerator('Codelab', codelabGenerator);
   playground.removeGenerator('JavaScript');
   playground.removeGenerator('Python');
   playground.removeGenerator('Lua');
   playground.removeGenerator('PHP');

Screenshot

I couldn't find unit tests for the addGenerator functionality, but please let me know if I should add unit tests for this (/ pointers to where I should add them) if needed. Thanks!

@rachel-fenichel
Copy link
Collaborator

Looks good! Thanks Josh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants