Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated CONTRIBUTING.md file to point at dev sites insead of GitHub wiki sites. #722

Merged
merged 2 commits into from
May 21, 2021

Conversation

ShiroRyokoshi
Copy link
Contributor

@ShiroRyokoshi ShiroRyokoshi commented May 18, 2021

Fixes #678. I hope I did everything correctly.

Copy link
Contributor

@maribethb maribethb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It looks great so far, just a few minor things to change.

- :arrow_right: Read up on how to [Add a Plugin](https://developers.google.com/blockly/guides/modify/contribute/add_a_plugin) or [Write a Codelab](https://developers.google.com/blockly/guides/modify/contribute/write_a_codelab)
- [Report bugs](https://github.com/google/blockly-samples/issues/new?assignees=&labels=type%3A+bug%2C+triage&template=bug_report.md)
- :arrow_right: Start by reading [How To Write A Good Issue](https://developers.google.com/blockly/guides/modify/contribute/write_a_good_issue)
- [Fix bugs](https://developers.google.com/blockly/guides/modify/contribute/issue_labels)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link should be on Finding a Good Issue below instead. Currently that one still links to the wiki. It should link to dev site instead and Fix bugs shouldn't have a link.


:arrow_right: Read more about our [PR review process](https://github.com/google/blockly-samples/wiki/The-Pull-Request-Review-Process) in the wiki.
:arrow_right: Read more about our [PR review process](https://developers.google.com/blockly/guides/modify/contribute/pr_review_process) in the wiki.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the text "in the wiki"


## Community guidelines

This project follows
[Google's Open Source Community Guidelines](https://opensource.google.com/conduct/).

## More information
Head over to the [wiki](https://github.com/google/blockly-samples/wiki) for more information, including an [overview of the repository structure](https://github.com/google/blockly-samples/wiki/Repository-Structure) and details of our [publishing process](https://github.com/google/blockly-samples/wiki/Plugin-Publishing).

Head over to the [wiki](https://developers.google.com/blockly/guides/modify/contributing) for more information, including an [overview of the repository structure](https://developers.google.com/blockly/guides/modify/contribute/samples_repository_structure) and details of our [publishing process](https://developers.google.com/blockly/guides/modify/contribute/add_a_plugin#publishing).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change "wiki" to "Developer Site"

@ShiroRyokoshi
Copy link
Contributor Author

Added those few minor things, you requested. Thank you.

Copy link
Contributor

@maribethb maribethb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CONTRIBUTING.md to point at dev site instead of wiki
2 participants