Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update keyboard nav to use new clipboard APIs #1088

Merged
merged 2 commits into from
Apr 5, 2022

Conversation

BeksOmega
Copy link
Contributor

Description

Updates keyboard nav to use the API added in google/blockly#5996 so that we're no longer using interal properties.

Also updates the plugin to use Blockly.clipboard.copy instead of Blockly.copy

Testing

  1. Opened the keyboard nav test playground.
  2. Added an if block to the workspace.
  3. Enabled keyboard nav.
  4. Copied the block.
  5. Selected the next input of the if block.
  6. Pasted.
  7. Observed how the pasted block was properly attached to the bottom of the original block.

All unit tests pass.

@BeksOmega BeksOmega requested a review from a team as a code owner April 4, 2022 22:37
@BeksOmega BeksOmega requested review from NeilFraser and removed request for a team April 4, 2022 22:37
@BeksOmega BeksOmega requested review from alschmiedt and removed request for NeilFraser April 4, 2022 22:42
@BeksOmega BeksOmega assigned alschmiedt and unassigned NeilFraser Apr 4, 2022
@BeksOmega BeksOmega merged commit cd49b87 into google:master Apr 5, 2022
@BeksOmega BeksOmega deleted the fix/keyboard-nav branch April 5, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants