Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding google/dagger #38

Open
perezd opened this issue Nov 18, 2018 · 4 comments
Open

Consider adding google/dagger #38

perezd opened this issue Nov 18, 2018 · 4 comments
Labels
enhancement New feature or request P4

Comments

@perezd
Copy link
Contributor

perezd commented Nov 18, 2018

Could be a worthwhile addition to this since it requires some annotation processor setup as well much like Auto.

@ronshapiro
Copy link
Collaborator

You're right that we should do this. I haven't figured out exactly how we should be interfacing with libraries that use bazel-common yet, so I'm hesitant to rush to something too quickly. But if you use bazel-common and then add a workspace dep on Dagger, everything should work

@perezd
Copy link
Contributor Author

perezd commented Nov 19, 2018 via email

@perezd
Copy link
Contributor Author

perezd commented Nov 28, 2018

I think its probably best to just depend on the jars from maven, seems like Bazel-based integration is broken pretty badly at the moment.

@ronshapiro
Copy link
Collaborator

I don't think that's a reason to rush this unfortunately. I don't think it's something we want long term.

But we can fix any of those issues (thanks for reporting them)! so that we can get things up to speed.

@cpovirk cpovirk added enhancement New feature or request P4 labels Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P4
Projects
None yet
Development

No branches or pull requests

3 participants