Update 2016-06-15 #346
Merged
Update 2016-06-15 #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
eamonnmcmanus
commented
Jun 15, 2016
eamonnmcmanus
commented
- The constructor of an @autovalue class that has a builder needs to have null checks if there are extensions, because in that case the constructor is package-private rather than private. Fixes Ctor null checks omitted when builder is present, but ctor still package-visible. #345.
- When scanning a Builder for referenced types, don't include non-abstract methods. The referenced types are used to determine the imports that will be needed by the implementing class, and that class never references non-abstract methods.
…can be used in releasing that product. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=124613659
…ve null checks if there are extensions, because in that case the constructor is package-private rather than private. Fixes google#345. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=124847338
…act methods. The referenced types are used to determine the imports that will be needed by the implementing class, and that class never references non-abstract methods. ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=124980576
|
Might want to reword my commit, since the only public piece is the removal of the nav. |
|
Or if you don't care enough LGTM. It's just inaccurate. /shruggie. |
|
Yeah, I don't think anybody cares. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.