Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dashboard in the demo app. #2414

Merged

Conversation

santosh-pingle
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #[issue number]

Description
Add dashboard in the demo app.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: Feature

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@santosh-pingle
Copy link
Collaborator Author

Screen.Recording.2024-01-25.at.14.31.13.mov

@santosh-pingle santosh-pingle marked this pull request as ready for review January 25, 2024 11:42
@santosh-pingle santosh-pingle requested a review from a team as a code owner January 25, 2024 11:42
@santosh-pingle santosh-pingle linked an issue Jan 31, 2024 that may be closed by this pull request
demo/src/main/res/values/dimens.xml Outdated Show resolved Hide resolved
demo/src/main/res/values/dimens.xml Outdated Show resolved Hide resolved
demo/src/main/res/values/dimens.xml Outdated Show resolved Hide resolved
demo/src/main/res/layout/fragment_home.xml Outdated Show resolved Hide resolved
demo/src/main/res/layout/fragment_home.xml Outdated Show resolved Hide resolved
demo/src/main/res/layout/fragment_home.xml Outdated Show resolved Hide resolved
Copy link
Collaborator

@MJ1998 MJ1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@santosh-pingle santosh-pingle enabled auto-merge (squash) February 2, 2024 06:19
@santosh-pingle santosh-pingle merged commit 6a7f890 into google:master Feb 2, 2024
3 checks passed
sharon2719 pushed a commit to opensrp/android-fhir that referenced this pull request Feb 6, 2024
* Implement dashboard in demo app.

* Update demo/src/main/res/layout/fragment_home.xml

* Update demo/src/main/res/layout/fragment_home.xml

* Update demo/src/main/res/values/dimens.xml

* Update demo/src/main/res/layout/fragment_home.xml

* Update demo/src/main/res/values/dimens.xml

* Update demo/src/main/res/values/dimens.xml

* Update unknown risk status color code.

---------

Co-authored-by: Santosh Pingle <spingle@google.com>
Co-authored-by: Jing Tang <jingtang@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Demo app reskinning.
3 participants