Quantity unit options with initial quantity value #2395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingtang10
approved these changes
Jan 15, 2024
.../main/java/com/google/android/fhir/datacapture/extensions/MoreQuestionnaireItemComponents.kt
Show resolved
Hide resolved
datacapture/src/main/java/com/google/android/fhir/datacapture/extensions/MoreTypes.kt
Outdated
Show resolved
Hide resolved
...c/main/java/com/google/android/fhir/datacapture/views/factories/QuantityViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
...c/main/java/com/google/android/fhir/datacapture/views/factories/QuantityViewHolderFactory.kt
Outdated
Show resolved
Hide resolved
jingtang10
requested changes
Jan 15, 2024
There was a problem hiding this comment.
oops, approved by mistake. please address previous comments!
thanks @maimoonak
…views/factories/QuantityViewHolderFactory.kt Co-authored-by: Jing Tang <jingtang@google.com>
jingtang10
approved these changes
Feb 21, 2024
datacapture/src/main/java/com/google/android/fhir/datacapture/extensions/MoreEnumerations.kt
Outdated
Show resolved
Hide resolved
...capture/src/test/java/com/google/android/fhir/datacapture/extensions/MoreEnumerationsTest.kt
Outdated
Show resolved
Hide resolved
maimoonak
force-pushed
the
cqf-quantity-date
branch
from
fbbb4ee
to
a8ff9e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2157
Description
As per fhir specs https://build.fhir.org/ig/HL7/sdc/behavior.html#initial an initial without decimal part of quantity type can be used for default unit reference purpose. The QuantityViewHolderFactory is now handling the unitoption with initial quantity used to specify default unit.
Type
Choose one: (Bug fix)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.